Make networks vms relations distinct #15783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make networks vms relations distinct, otherwise the Vm count could be shown as higher, if the the vm has multiple ports plugged into the same network. Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1479667
|
before(the VMs counts differ): after(the VMs counts are the same): |
|
Checked commit Ladas@77a77d7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
reviewed
Aug 10, 2017
|
@agrare hm, not sure. The specs should test the correct counts now. I think we don't have Vm connected to the same network with 2 ports tested. But seems like it is in the spec data. :-) |
|
Yeah if the tests fail because of this change they were wrong in the first place :) but we should keep an eye on it and update if any fail after this change. |
agrare
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make networks vms relations distinct, otherwise the Vm count
could be shown as higher, if the the vm has multiple ports
plugged into the same network.
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1479667